Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win] Use getName(true) instead of gettext when loading eclipsing body names #1929

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[win] Use getName(true) instead of gettext when loading eclipsing body names #1929

merged 1 commit into from
Oct 6, 2023

Conversation

ajtribick
Copy link
Collaborator

Body already stores the localized name so use that rather than translating it again.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ajtribick ajtribick merged commit 93387b2 into CelestiaProject:master Oct 6, 2023
11 checks passed
@ajtribick ajtribick deleted the win-eclipse-finder branch October 6, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@375gnu 375gnu 375gnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajtribick @375gnu